netdev - Re: [PATCH net-next 1/2] net: phy: Support set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YR0hQ6UmtmGNg2AW@lunn.ch>
Date:   Wed, 18 Aug 2021 17:03:31 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: phy: Support set_loopback override

On Wed, Aug 18, 2021 at 02:27:35PM +0200, Gerhard Engleder wrote:
> phy_read_status and various other PHY functions support PHY specific
> overriding of driver functions by using a PHY specific pointer to the
> PHY driver. Add support of PHY specific override to phy_loopback too.
> 
> Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>
> ---
>  drivers/net/phy/phy_device.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 107aa6d7bc6b..ba5ad86ec826 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -1821,11 +1821,10 @@ EXPORT_SYMBOL(phy_resume);
>  
>  int phy_loopback(struct phy_device *phydev, bool enable)
>  {
> -	struct phy_driver *phydrv = to_phy_driver(phydev->mdio.dev.driver);
>  	int ret = 0;
>  
> -	if (!phydrv)
> -		return -ENODEV;
> +	if (!phydev->drv)
> +		return -EIO;

Humm, we need to take a closer look at what uses to_phy_driver() and
what uses phydev->drv. Do they need to be different? Can we make it
uniform?

	Andrew