netdev - Re: [PATCH net 1/1] ice: do not abort devlink info if PBA can't be found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210819095241.502dac9f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 19 Aug 2021 09:52:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, Jacob Keller <jacob.e.keller@...el.com>,
        netdev@...r.kernel.org, Tony Brelinski <tonyx.brelinski@...el.com>
Subject: Re: [PATCH net 1/1] ice: do not abort devlink info if PBA can't be
 found

On Wed, 18 Aug 2021 10:46:59 -0700 Tony Nguyen wrote:
> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> The devlink dev info command reports version information about the
> device and firmware running on the board. This includes the "board.id"
> field which is supposed to represent an identifier of the board design.
> The ice driver uses the Product Board Assembly identifier for this.
> 
> In some cases, the PBA is not present in the NVM. If this happens,
> devlink dev info will fail with an error. Instead, modify the
> ice_info_pba function to just exit without filling in the context
> buffer. This will cause the board.id field to be skipped. Log a dev_dbg
> message in case someone wants to confirm why board.id is not showing up
> for them.
> 
> While at it, notice that none of the getter/fallback() functions report
> an error anymore. Convert the interface to a void so that it is no
> longer possible to add a version field that is fatal. This makes sense,
> because we should not fail to report other versions just because one of
> the version pieces could not be found.
> 
> Finally, clean up the getter functions line wrapping so that none of
> them take more than 80 columns, as is the usual style for networking
> files.
> 
> Fixes: e961b679fb0b ("ice: add board identifier info to devlink .info_get")
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Tested-by: Tony Brelinski <tonyx.brelinski@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_devlink.c | 137 +++++++------------
>  1 file changed, 53 insertions(+), 84 deletions(-)

This is on the 'long' side, please just fix the bug and leave 
the refactoring for -next.