netdev - Re: [PATCH net] Revert "flow_offload: action should not be NULL when it is referenced"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210819111516.5b7b7a66@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 19 Aug 2021 11:15:16 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...dia.com,
        Ido Schimmel <idosch@...dia.com>,
        gushengxian <gushengxian@...ong.com>
Subject: Re: [PATCH net] Revert "flow_offload: action should not be NULL
 when it is referenced"

On Thu, 19 Aug 2021 07:51:15 -0400 Jamal Hadi Salim wrote:
> On 2021-08-19 6:58 a.m., Ido Schimmel wrote:
> > From: Ido Schimmel <idosch@...dia.com>
> > 
> > This reverts commit 9ea3e52c5bc8bb4a084938dc1e3160643438927a.
> > 
> > Cited commit added a check to make sure 'action' is not NULL, but
> > 'action' is already dereferenced before the check, when calling
> > flow_offload_has_one_action().
> > 
> > Therefore, the check does not make any sense and results in a smatch
> > warning:
> > 
> > include/net/flow_offload.h:322 flow_action_mixed_hw_stats_check() warn:
> > variable dereferenced before check 'action' (see line 319)
> > 
> > Fix by reverting this commit.
> > 
> > Cc: gushengxian <gushengxian@...ong.com>
> > Fixes: 9ea3e52c5bc8 ("flow_offload: action should not be NULL when it is referenced")
> > Signed-off-by: Ido Schimmel <idosch@...dia.com>  
> 
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

Applied, thanks!