netdev - Re: [PATCH net] net: dpaa2-switch: disable the control interface on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210819111539.71d76241@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 19 Aug 2021 11:15:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ioana Ciornei <ioana.ciornei@....com>,
        Vladimir Oltean <vladimir.oltean@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] net: dpaa2-switch: disable the control interface on
 error path

On Thu, 19 Aug 2021 15:29:49 +0000 Ioana Ciornei wrote:
> On Thu, Aug 19, 2021 at 05:17:55PM +0300, Vladimir Oltean wrote:
> > Currently dpaa2_switch_takedown has a funny name and does not do the
> > opposite of dpaa2_switch_init, which makes probing fail when we need to
> > handle an -EPROBE_DEFER.

> > [E, ctrl_if_set_pools:2211, DPMNG]  ctrl_if must be disabled
> > 
> > So make dpaa2_switch_takedown do the opposite of dpaa2_switch_init (in
> > reasonable limits, no reason to change STP state, re-add VLANs etc), and
> > rename it to something more conventional, like dpaa2_switch_teardown.
> > 
> > Fixes: 613c0a5810b7 ("staging: dpaa2-switch: enable the control interface")
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>  
> 
> Reviewed-by: Ioana Ciornei <ioana.ciornei@....com>

Applied, thanks!