netdev - Re: [PATCH] net: qrtr: fix another OOB Read in qrtr_endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e24737f1-5793-805a-5979-ec564ab1db13@gmail.com>
Date:   Fri, 20 Aug 2021 00:16:06 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     butt3rflyh4ck <butterflyhuangxx@...il.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        butt3rflyh4ck <butterflyhhuangxx@...il.com>,
        bjorn.andersson@...aro.org
Subject: Re: [PATCH] net: qrtr: fix another OOB Read in qrtr_endpoint_post

On 8/20/21 12:02 AM, Jakub Kicinski wrote:
> On Thu, 19 Aug 2021 23:24:39 +0300 Pavel Skripkin wrote:
>> On 8/19/21 11:06 PM, butt3rflyh4ck wrote:
>> > Yes, this bug can be triggered without your change. The reason why I
>> > point to your commit is to make it easier for everyone to understand
>> > this bug.
>> 
>> As I understand, purpose of Fixes: tag is to point to commit where the 
>> bug was introduced. I could be wrong, so it's up to maintainer to decide 
>> is this Fixes: tag is needed or not :)
> 
> You're right thanks for pointing that out. May it should actually be:
> 
> Fixes: 0baa99ee353c ("net: qrtr: Allow non-immediate node routing") ?
> 

Yes, this is correct one. I guess, patch author has chosen 194ccc88297a, 
because my commit has same Fixes: tag (wrong one, btw).


With regards,
Pavel Skripkin