netdev - Re: [PATCH net-next v2] net: ipvs: add sysctl_run_estimation to support disable estimation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202108191644.QJhpxuWp-lkp@intel.com>
Date:   Thu, 19 Aug 2021 16:23:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dust Li <dust.li@...ux.alibaba.com>, Julian Anastasov <ja@....bg>,
        Simon Horman <horms@...ge.net.au>,
        Wensong Zhang <wensong@...ux-vs.org>
Cc:     kbuild-all@...ts.01.org, lvs-devel@...r.kernel.org,
        netdev@...r.kernel.org, yunhong-cgl jiang <xintian1976@...il.com>
Subject: Re: [PATCH net-next v2] net: ipvs: add sysctl_run_estimation to
 support disable estimation

Hi Dust,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Dust-Li/net-ipvs-add-sysctl_run_estimation-to-support-disable-estimation/20210819-125335
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 19b8ece42c56aaa122f7e91eb391bb3dd7e193cd
config: ia64-randconfig-r024-20210818 (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8f0f8c6b2f04fe397ca8df17353590cdd2f5a414
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dust-Li/net-ipvs-add-sysctl_run_estimation-to-support-disable-estimation/20210819-125335
        git checkout 8f0f8c6b2f04fe397ca8df17353590cdd2f5a414
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash net/netfilter/ipvs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/net/checksum.h:21,
                    from include/net/ip_vs.h:23,
                    from net/netfilter/ipvs/ip_vs_lc.c:18:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:48: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     127 |         unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                                ^~~~~~~
   In file included from net/netfilter/ipvs/ip_vs_lc.c:18:
   include/net/ip_vs.h: At top level:
>> include/net/ip_vs.h:1660:19: error: redefinition of 'sysctl_run_estimation'
    1660 | static inline int sysctl_run_estimation(struct netns_ipvs *ipvs)
         |                   ^~~~~~~~~~~~~~~~~~~~~
   include/net/ip_vs.h:1075:19: note: previous definition of 'sysctl_run_estimation' with type 'int(struct netns_ipvs *)'
    1075 | static inline int sysctl_run_estimation(struct netns_ipvs *ipvs)
         |                   ^~~~~~~~~~~~~~~~~~~~~
--
   In file included from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from include/linux/mm.h:33,
                    from include/linux/bvec.h:14,
                    from include/linux/skbuff.h:17,
                    from include/linux/ip.h:16,
                    from net/netfilter/ipvs/ip_vs_core.c:27:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:48: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     127 |         unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                                ^~~~~~~
   In file included from net/netfilter/ipvs/ip_vs_core.c:52:
   include/net/ip_vs.h: At top level:
>> include/net/ip_vs.h:1660:19: error: redefinition of 'sysctl_run_estimation'
    1660 | static inline int sysctl_run_estimation(struct netns_ipvs *ipvs)
         |                   ^~~~~~~~~~~~~~~~~~~~~
   include/net/ip_vs.h:1075:19: note: previous definition of 'sysctl_run_estimation' with type 'int(struct netns_ipvs *)'
    1075 | static inline int sysctl_run_estimation(struct netns_ipvs *ipvs)
         |                   ^~~~~~~~~~~~~~~~~~~~~
   net/netfilter/ipvs/ip_vs_core.c: In function 'ip_vs_in_icmp':
   net/netfilter/ipvs/ip_vs_core.c:1643:15: warning: variable 'outer_proto' set but not used [-Wunused-but-set-variable]
    1643 |         char *outer_proto = "IPIP";
         |               ^~~~~~~~~~~


vim +/sysctl_run_estimation +1660 include/net/ip_vs.h

  1659	
> 1660	static inline int sysctl_run_estimation(struct netns_ipvs *ipvs)
  1661	{
  1662		return 1;
  1663	}
  1664	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (32294 bytes)