netdev - Re: [PATCH net-next] doc: Document unexpected tcp_l3mdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5254c616-dc21-1e41-9923-59aade8a4731@gmail.com>
Date:   Fri, 20 Aug 2021 11:06:34 -0600
From:   David Ahern <dsahern@...il.com>
To:     Benjamin Poirier <bpoirier@...dia.com>,
        David Ahern <dsahern@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Corbet <corbet@....net>, netdev@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next] doc: Document unexpected tcp_l3mdev_accept=1
 behavior

On 8/19/21 2:38 AM, Benjamin Poirier wrote:
> As suggested by David, document a somewhat unexpected behavior that results
> from net.ipv4.tcp_l3mdev_accept=1. This behavior was encountered while
> debugging FRR, a VRF-aware application, on a system which used
> net.ipv4.tcp_l3mdev_accept=1 and where TCP connections for BGP with MD5
> keys were failing to establish.
> 
> Cc: David Ahern <dsahern@...il.com>
> Signed-off-by: Benjamin Poirier <bpoirier@...dia.com>
> ---
>  Documentation/networking/vrf.rst | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/networking/vrf.rst b/Documentation/networking/vrf.rst
> index 0dde145043bc..0a9a6f968cb9 100644
> --- a/Documentation/networking/vrf.rst
> +++ b/Documentation/networking/vrf.rst
> @@ -144,6 +144,19 @@ default VRF are only handled by a socket not bound to any VRF::
>  netfilter rules on the VRF device can be used to limit access to services
>  running in the default VRF context as well.
>  
> +Using VRF-aware applications (applications which simultaneously create sockets
> +outside and inside VRFs) in conjunction with ``net.ipv4.tcp_l3mdev_accept=1``
> +is possible but may lead to problems in some situations. With that sysctl
> +value, it is unspecified which listening socket will be selected to handle
> +connections for VRF traffic; ie. either a socket bound to the VRF or an unbound
> +socket may be used to accept new connections from a VRF. This somewhat
> +unexpected behavior can lead to problems if sockets are configured with extra
> +options (ex. TCP MD5 keys) with the expectation that VRF traffic will
> +exclusively be handled by sockets bound to VRFs, as would be the case with
> +``net.ipv4.tcp_l3mdev_accept=0``. Finally and as a reminder, regardless of
> +which listening socket is selected, established sockets will be created in the
> +VRF based on the ingress interface, as documented earlier.
> +
>  --------------------------------------------------------------------------------
>  
>  Using iproute2 for VRFs
> 

Reviewed-by: David Ahern <dsahern@...nel.org>


I don't have the cycles right now, but if you or someone else has time
it would be good to look at ways to improve the current situation.