netdev - Re: [PATCH bpf-next] libbpf: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 Aug 2021 13:06:04 -0500
From:   Mauricio Vásquez Bernal <mauricio@...volk.io>
To:     netdev@...r.kernel.org, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Mauricio Vásquez <mauriciov@...rosoft.com>
Subject: Re: [PATCH bpf-next] libbpf: remove unused variable

On Fri, Aug 20, 2021 at 11:55 AM Mauricio Vásquez <mauricio@...volk.io> wrote:
>
> From: Mauricio Vásquez <mauriciov@...rosoft.com>
>
> Fixes: ddc7c3042614 ("libbpf: implement BPF CO-RE offset relocation algorithm")
>
> Signed-off-by: Mauricio Vásquez <mauriciov@...rosoft.com>
> ---
>  tools/lib/bpf/relo_core.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git tools/lib/bpf/relo_core.c tools/lib/bpf/relo_core.c
> index 4016ed492d0c..52d8125b7cbe 100644
> --- tools/lib/bpf/relo_core.c
> +++ tools/lib/bpf/relo_core.c
> @@ -417,13 +417,6 @@ static int bpf_core_match_member(const struct btf *local_btf,
>                                 return found;
>                 } else if (strcmp(local_name, targ_name) == 0) {
>                         /* matching named field */
> -                       struct bpf_core_accessor *targ_acc;
> -
> -                       targ_acc = &spec->spec[spec->len++];
> -                       targ_acc->type_id = targ_id;
> -                       targ_acc->idx = i;
> -                       targ_acc->name = targ_name;
> -
>                         *next_targ_id = m->type;
>                         found = bpf_core_fields_are_compat(local_btf,
>                                                            local_member->type,
> --
> 2.25.1
>

Forget that, it's used indeed. Sorry for the noise.