netdev - Re: [PATCH] ptp: ocp: don't allow on S390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3QGF2=WZz6N8wQo2ZQxmVqKToHGmhT4wEtB7tAL+-ruQ@mail.gmail.com>
Date:   Fri, 20 Aug 2021 12:45:42 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Networking <netdev@...r.kernel.org>,
        Richard Cochran <richardcochran@...il.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>
Subject: Re: [PATCH] ptp: ocp: don't allow on S390

On Fri, Aug 13, 2021 at 10:30 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Fix kconfig warning on arch/s390/:
>
> WARNING: unmet direct dependencies detected for SERIAL_8250
>   Depends on [n]: TTY [=y] && HAS_IOMEM [=y] && !S390 [=y]
>   Selected by [m]:
>   - PTP_1588_CLOCK_OCP [=m] && PTP_1588_CLOCK [=m] && HAS_IOMEM [=y] && PCI [=y] && SPI [=y] && I2C [=m] && MTD [=m]
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Richard Cochran <richardcochran@...il.com>
> Cc: Jonathan Lemon <jonathan.lemon@...il.com>
> ---
> There is no 8250 serial on S390. See commit 1598e38c0770.
> Is this driver useful even without 8250 serial?

I think an easier way to do this would be to remove the
'select SERIAL_8250', I don't think that is actually a compile-time
dependency, just something that you normally want to enable
to make the device useful.

I would also suggest removing all the 'imply' statements, they
usually don't do what the original author intended anyway.
If there is a compile-time dependency with those drivers,
it should be 'depends on', otherwise they can normally be
left out.

       Arnd