netdev - Re: [PATCH v2 2/2] net: Add driver for LiteX's LiteEth network interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202108201919.xXdbj4RS-lkp@intel.com>
Date:   Fri, 20 Aug 2021 19:50:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Joel Stanley <joel@....id.au>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     kbuild-all@...ts.01.org, Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Gabriel Somlo <gsomlo@...il.com>,
        David Shah <dave@....me>
Subject: Re: [PATCH v2 2/2] net: Add driver for LiteX's LiteEth network
 interface

Hi Joel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on net-next/master net/master linus/master v5.14-rc6 next-20210819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Joel-Stanley/net-Add-LiteETH-network-driver/20210820-154958
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3355b2a96c6d9881128ebac1d3801171b988dbeb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Joel-Stanley/net-Add-LiteETH-network-driver/20210820-154958
        git checkout 3355b2a96c6d9881128ebac1d3801171b988dbeb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/litex/litex_liteeth.c:204:5: warning: no previous prototype for 'liteeth_setup_slots' [-Wmissing-prototypes]
     204 | int liteeth_setup_slots(struct liteeth *priv)
         |     ^~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/liteeth_setup_slots +204 drivers/net/ethernet/litex/litex_liteeth.c

   203	
 > 204	int liteeth_setup_slots(struct liteeth *priv)
   205	{
   206		struct device_node *np = priv->dev->of_node;
   207		int err, depth;
   208	
   209		err = of_property_read_u32(np, "rx-fifo-depth", &depth);
   210		if (err) {
   211			dev_err(priv->dev, "unable to get rx-fifo-depth\n");
   212			return err;
   213		}
   214		if (depth < LITEETH_BUFFER_SIZE) {
   215			dev_err(priv->dev, "invalid tx-fifo-depth: %d\n", depth);
   216			return -EINVAL;
   217		}
   218		priv->num_rx_slots = depth / LITEETH_BUFFER_SIZE;
   219	
   220		err = of_property_read_u32(np, "tx-fifo-depth", &depth);
   221		if (err) {
   222			dev_err(priv->dev, "unable to get tx-fifo-depth\n");
   223			return err;
   224		}
   225		if (depth < LITEETH_BUFFER_SIZE) {
   226			dev_err(priv->dev, "invalid rx-fifo-depth: %d\n", depth);
   227			return -EINVAL;
   228		}
   229		priv->num_tx_slots = depth / LITEETH_BUFFER_SIZE;
   230	
   231		return 0;
   232	}
   233	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (55043 bytes)