netdev - Re: [RFC PATCH net-next 3/5] net: dsa: tag_rtl8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4a2302e-b961-fc2d-c0f3-c3123dbaab83@bang-olufsen.dk>
Date:   Sun, 22 Aug 2021 23:27:11 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Alvin Šipraga <alvin@...s.dk>,
        Linus Walleij <linus.walleij@...aro.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Michael Rasmussen <MIR@...g-olufsen.dk>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH net-next 3/5] net: dsa: tag_rtl8_4: add realtek 8 byte
 protocol 4 tag

Hi Andrew,

On 8/23/21 1:14 AM, Andrew Lunn wrote:
>>>> + */
>>>> +
>>>> +#include <linux/etherdevice.h>
>>>> +#include <linux/bits.h>
>>>> +
>>>> +#include "dsa_priv.h"
>>>> +
>>>> +#define RTL8_4_TAG_LEN			8
>>>> +#define RTL8_4_ETHERTYPE		0x8899
>>>
>>> Please add this to include/uapi/linux/if_ether.h
> 
> Maybe call it ETH_P_REALTEK, and comment /* Multiple Proprietary
> protocols */ ?
> 
> If you do it in an individual patch, you can explain more in the
> commit message about it being used for different protocols by Realtek,
> and that no assumptions should be made when trying to decode it.

Sounds good, I'll do that in v2.

> 
> 	  Andrew
>