netdev - Re: [PATCH 05/12] bnx2x: Read VPD with pci_vpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 23 Aug 2021 01:42:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Ariel Elior <aelior@...vell.com>,
        Sudarsana Kalluru <skalluru@...vell.com>,
        GR-everest-linux-l2@...vell.com, Jakub Kicinski <kuba@...nel.org>,
        David Härdeman <david@...deman.nu>
Cc:     kbuild-all@...ts.01.org,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 05/12] bnx2x: Read VPD with pci_vpd_alloc()

Hi Heiner,

I love your patch! Perhaps something to improve:

[auto build test WARNING on scsi/for-next]
[also build test WARNING on pci/next mkp-scsi/for-next linus/master v5.14-rc6 next-20210820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Heiner-Kallweit/PCI-VPD-Convert-more-users-to-the-new-VPD-API-functions/20210822-220229
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/11d3b0532e225fec84b84c082ff913ab35cecd29
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Heiner-Kallweit/PCI-VPD-Convert-more-users-to-the-new-VPD-API-functions/20210822-220229
        git checkout 11d3b0532e225fec84b84c082ff913ab35cecd29
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function 'bnx2x_read_fwinfo':
   drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12200:20: error: implicit declaration of function 'pci_vpd_alloc'; did you mean 'pci_pool_alloc'? [-Werror=implicit-function-declaration]
   12200 |         vpd_data = pci_vpd_alloc(bp->pdev, &vpd_len);
         |                    ^~~~~~~~~~~~~
         |                    pci_pool_alloc
>> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:12200:18: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
   12200 |         vpd_data = pci_vpd_alloc(bp->pdev, &vpd_len);
         |                  ^
   cc1: some warnings being treated as errors


vim +12200 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

 12189	
 12190	static void bnx2x_read_fwinfo(struct bnx2x *bp)
 12191	{
 12192		int i, block_end, rodi;
 12193		char str_id_reg[VENDOR_ID_LEN+1];
 12194		char str_id_cap[VENDOR_ID_LEN+1];
 12195		unsigned int vpd_len;
 12196		u8 *vpd_data, len;
 12197	
 12198		memset(bp->fw_ver, 0, sizeof(bp->fw_ver));
 12199	
 12200		vpd_data = pci_vpd_alloc(bp->pdev, &vpd_len);
 12201		if (IS_ERR(vpd_data))
 12202			return;
 12203	
 12204		/* VPD RO tag should be first tag after identifier string, hence
 12205		 * we should be able to find it in first BNX2X_VPD_LEN chars
 12206		 */
 12207		i = pci_vpd_find_tag(vpd_data, vpd_len, PCI_VPD_LRDT_RO_DATA);
 12208		if (i < 0)
 12209			goto out_not_found;
 12210	
 12211		block_end = i + PCI_VPD_LRDT_TAG_SIZE +
 12212			    pci_vpd_lrdt_size(&vpd_data[i]);
 12213		i += PCI_VPD_LRDT_TAG_SIZE;
 12214	
 12215		rodi = pci_vpd_find_info_keyword(vpd_data, i, block_end,
 12216					   PCI_VPD_RO_KEYWORD_MFR_ID);
 12217		if (rodi < 0)
 12218			goto out_not_found;
 12219	
 12220		len = pci_vpd_info_field_size(&vpd_data[rodi]);
 12221	
 12222		if (len != VENDOR_ID_LEN)
 12223			goto out_not_found;
 12224	
 12225		rodi += PCI_VPD_INFO_FLD_HDR_SIZE;
 12226	
 12227		/* vendor specific info */
 12228		snprintf(str_id_reg, VENDOR_ID_LEN + 1, "%04x", PCI_VENDOR_ID_DELL);
 12229		snprintf(str_id_cap, VENDOR_ID_LEN + 1, "%04X", PCI_VENDOR_ID_DELL);
 12230		if (!strncmp(str_id_reg, &vpd_data[rodi], VENDOR_ID_LEN) ||
 12231		    !strncmp(str_id_cap, &vpd_data[rodi], VENDOR_ID_LEN)) {
 12232	
 12233			rodi = pci_vpd_find_info_keyword(vpd_data, i, block_end,
 12234							PCI_VPD_RO_KEYWORD_VENDOR0);
 12235			if (rodi >= 0) {
 12236				len = pci_vpd_info_field_size(&vpd_data[rodi]);
 12237	
 12238				rodi += PCI_VPD_INFO_FLD_HDR_SIZE;
 12239	
 12240				if (len < 32 && (len + rodi) <= vpd_len) {
 12241					memcpy(bp->fw_ver, &vpd_data[rodi], len);
 12242					bp->fw_ver[len] = ' ';
 12243				}
 12244			}
 12245		}
 12246	out_not_found:
 12247		kfree(vpd_data);
 12248	}
 12249	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (68217 bytes)