netdev - Re: [PATCH linux-next] tools:test_xdp_noinline: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210824074657.363455a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 24 Aug 2021 07:46:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     CGEL <cgel.zte@...il.com>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Yonghong Song <yhs@...com>, netdev@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jing Yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] tools:test_xdp_noinline: fix
 boolreturn.cocci warnings

On Tue, 24 Aug 2021 08:42:15 -0600 Shuah Khan wrote:
> On 8/24/21 12:55 AM, CGEL wrote:
> > From: Jing Yangyang <jing.yangyang@....com.cn>
> > 
> > Return statements in functions returning bool should use true/false
> > instead of 1/0.
> > 
> > Reported-by: Zeal Robot <zealci@....com.cn>
> > Signed-off-by: Jing Yangyang <jing.yangyang@....com.cn>
> 
> We can't accept this patch. The from and Signed-off-by don't match.

That's what I thought but there is a From in the email body which git
will pick up. The submission is correct.

Please trim your responses.