netdev - Re: [PATCH RESEND ethtool-next] netlink: settings: add two link extended substates of bad signal integrity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210824173614.mkv5i72sutxtdvrk@lion.mk-sys.cz>
Date:   Tue, 24 Aug 2021 19:36:14 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Guangbin Huang <huangguangbin2@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, amitc@...lanox.com,
        idosch@...sch.org, andrew@...n.ch, o.rempel@...gutronix.de,
        f.fainelli@...il.com, jacob.e.keller@...el.com, mlxsw@...lanox.com,
        netdev@...r.kernel.org, lipeng321@...wei.com
Subject: Re: [PATCH RESEND ethtool-next] netlink: settings: add two link
 extended substates of bad signal integrity

On Tue, Aug 24, 2021 at 10:14:51AM +0800, Guangbin Huang wrote:
> Add two link extended substates of bad signal integrity available in the
> kernel.
> 
> ETHTOOL_LINK_EXT_SUBSTATE_BSI_SERDES_REFERENCE_CLOCK_LOST means the input
> external clock signal for SerDes is too weak or lost.
> 
> ETHTOOL_LINK_EXT_SUBSTATE_BSI_SERDES_ALOS means the received signal for
> SerDes is too weak because analog loss of signal.
> 
> Signed-off-by: Guangbin Huang <huangguangbin2@...wei.com>
> ---
>  netlink/settings.c   | 4 ++++
>  uapi/linux/ethtool.h | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/netlink/settings.c b/netlink/settings.c
> index e47a38f3058f..6d10a0703861 100644
> --- a/netlink/settings.c
> +++ b/netlink/settings.c
> @@ -639,6 +639,10 @@ static const char *const names_bad_signal_integrity_link_ext_substate[] = {
>  		"Large number of physical errors",
>  	[ETHTOOL_LINK_EXT_SUBSTATE_BSI_UNSUPPORTED_RATE]		=
>  		"Unsupported rate",
> +	[ETHTOOL_LINK_EXT_SUBSTATE_BSI_SERDES_REFERENCE_CLOCK_LOST]	=
> +		"Serdes reference clock lost",
> +	[ETHTOOL_LINK_EXT_SUBSTATE_BSI_SERDES_ALOS]			=
> +		"Serdes ALOS",
>  };
>  
>  static const char *const names_cable_issue_link_ext_substate[] = {
> diff --git a/uapi/linux/ethtool.h b/uapi/linux/ethtool.h
> index c6ec1111ffa3..bd1f09b23cf5 100644
> --- a/uapi/linux/ethtool.h
> +++ b/uapi/linux/ethtool.h
> @@ -637,6 +637,8 @@ enum ethtool_link_ext_substate_link_logical_mismatch {
>  enum ethtool_link_ext_substate_bad_signal_integrity {
>  	ETHTOOL_LINK_EXT_SUBSTATE_BSI_LARGE_NUMBER_OF_PHYSICAL_ERRORS = 1,
>  	ETHTOOL_LINK_EXT_SUBSTATE_BSI_UNSUPPORTED_RATE,
> +	ETHTOOL_LINK_EXT_SUBSTATE_BSI_SERDES_REFERENCE_CLOCK_LOST,
> +	ETHTOOL_LINK_EXT_SUBSTATE_BSI_SERDES_ALOS,
>  };
>  
>  /* More information in addition to ETHTOOL_LINK_EXT_STATE_CABLE_ISSUE. */

Please split the uapi header update into a separate patch and update all
headers to a specific commit (preferrably current net-next head) as
described in the last section of

  https://www.kernel.org/pub/software/network/ethtool/devel.html

The patch looks good otherwise.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)