netdev - Re: [PATCH net-next v2 2/2] page_pool: optimize the cpu sync operation when DMA mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Aug 2021 15:00:54 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     Ilias Apalodimas <ilias.apalodimas@...aro.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <hawk@...nel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <hkallweit1@...il.com>
Subject: Re: [PATCH net-next v2 2/2] page_pool: optimize the cpu sync
 operation when DMA mapping

On 2021/8/23 20:42, Ilias Apalodimas wrote:
> On Mon, Aug 23, 2021 at 11:56:48AM +0800, Yunsheng Lin wrote:
>> On 2021/8/20 17:39, Ilias Apalodimas wrote:
>>> On Fri, Aug 20, 2021 at 02:56:51PM +0800, Yunsheng Lin wrote:

[..]
>>
>> https://elixir.bootlin.com/linux/latest/source/kernel/dma/direct.h#L104
>>
>> The one thing I am not sure about is that the pool->p.offset
>> and pool->p.max_len are used to decide the sync range before this
>> patch, while the sync range is the same as the map range when doing
>> the sync in dma_map_page_attrs().
> 
> I am not sure I am following here. We always sync the entire range as well
> in the current code as the mapping function is called with max_len.
> 
>>
>> I assumed the above is not a issue? only sync more than we need?
>> and it won't hurt the performance?
> 
> We can sync more than we need, but if it's a non-coherent architecture,
> there's a performance penalty. 

Since I do not have any performance data to prove if there is a
performance penalty for non-coherent architecture, I will drop it:)

> 
> Regards
> /Ilias
>>