netdev - Re: [PATCH net 2/2] net: dsa: hellcreek: Adjust schedule look ahead window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd749cff-9f9b-3757-4155-3a705b4b93db@gmail.com>
Date:   Wed, 25 Aug 2021 18:34:29 +0200
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Kurt Kanzenbach <kurt@...utronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>, netdev@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH net 2/2] net: dsa: hellcreek: Adjust schedule look ahead
 window



On 8/25/2021 3:58 PM, Kurt Kanzenbach wrote:
> Traffic schedules can only be started up to eight seconds within the
> future. Therefore, the driver periodically checks every two seconds whether the
> admin base time provided by the user is inside that window. If so the schedule
> is started. Otherwise the check is deferred.

Uber nit: this probably ought to be just one sentence starting from 
"Therefore" and ending at deferred.

> 
> However, according to the programming manual the look ahead window size should
> be four - not eight - seconds. By using the proposed value of four seconds
> starting a schedule at a specified admin base time actually works as expected.
> 
> Fixes: 24dfc6eb39b2 ("net: dsa: hellcreek: Add TAPRIO offloading support")
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian