netdev - Re: [PATCH] can: mscan: mpc5xxx_can: Remove useless BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Aug 2021 08:12:55 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     davem@...emloft.net, wg@...ndegger.com, kuba@...nel.org,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: mscan: mpc5xxx_can: Remove useless BUG_ON()

On 23.08.2021 22:10:33, Tang Bin wrote:
> In the function mpc5xxx_can_probe(), the variale 'data'
                                               ^b

Fixed typo while applying.

> has already been determined in the above code, so the
> BUG_ON() in this place is useless, remove it.
> 
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---
>  drivers/net/can/mscan/mpc5xxx_can.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c
> index 3b7465acd..35892c1ef 100644
> --- a/drivers/net/can/mscan/mpc5xxx_can.c
> +++ b/drivers/net/can/mscan/mpc5xxx_can.c
> @@ -317,7 +317,6 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev)
>  
>  	clock_name = of_get_property(np, "fsl,mscan-clock-source", NULL);
>  
> -	BUG_ON(!data);
>  	priv->type = data->type;
>  	priv->can.clock.freq = data->get_clock(ofdev, clock_name,
>  					       &mscan_clksrc);

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)