netdev - Re: [PATCH net-next] ptp: ocp: Simplify Kconfig.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09355764-4444-e530-c14b-1f3d9d947b61@infradead.org>
Date:   Wed, 25 Aug 2021 16:22:46 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Jonathan Lemon <jonathan.lemon@...il.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, arnd@...nel.org,
        richardcochran@...il.com, kernel-team@...com
Subject: Re: [PATCH net-next] ptp: ocp: Simplify Kconfig.

On 8/25/21 2:17 PM, Jonathan Lemon wrote:
> Remove the 'imply' statements, these apparently are not doing
> what I expected.  Platform modules which are used by the driver
> still need to be enabled in the overall config for them to be
> used, but there isn't a hard dependency on them.
> 
> Use 'depend' for selectable modules which provide functions
> used directly by the driver.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>
> ---
>   drivers/ptp/Kconfig | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> index 32660dc11354..f02bedf41264 100644
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -171,16 +171,10 @@ config PTP_1588_CLOCK_OCP
>   	tristate "OpenCompute TimeCard as PTP clock"
>   	depends on PTP_1588_CLOCK
>   	depends on HAS_IOMEM && PCI
> -	depends on SPI && I2C && MTD
> +	depends on I2C && MTD
> +	depends on SERIAL_8250
>   	depends on !S390
> -	imply SPI_MEM
> -	imply SPI_XILINX
> -	imply MTD_SPI_NOR
> -	imply I2C_XILINX
> -	select SERIAL_8250
>   	select NET_DEVLINK
> -
> -	default n
>   	help
>   	  This driver adds support for an OpenCompute time card.
>   
> 

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

-- 
~Randy