netdev - Re: [PATCH iproute2-next 01/17] ip: bridge: add support for mcast_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3594d516-288c-d84e-83ec-91c5288b452c@blackwall.org>
Date:   Thu, 26 Aug 2021 18:11:08 +0300
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, roopa@...dia.com,
        Joachim Wiberg <troglobit@...il.com>, dsahern@...il.com,
        Nikolay Aleksandrov <nikolay@...dia.com>
Subject: Re: [PATCH iproute2-next 01/17] ip: bridge: add support for
 mcast_vlan_snooping

On 26/08/2021 18:08, Stephen Hemminger wrote:
> On Thu, 26 Aug 2021 16:05:17 +0300
> Nikolay Aleksandrov <razor@...ckwall.org> wrote:
> 
>> +		} else if (matches(*argv, "mcast_vlan_snooping") == 0) {
>> +			__u32 mcvl_bit = 1 << BR_BOOLOPT_MCAST_VLAN_SNOOPING;
> 
> Using matches() is problematic.  since it will change how 'mcast' is
> handled.
> 
> Overall, bridge command (and rest of iproute2) needs to move
> away from matches
> 

Sure, I can send a follow up if you don't mind to switch all matches calls. I used it
to be in line with the current code.