netdev - [PATCH] qrtr: mhi: Fix duplicate channel start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1629992163-6252-1-git-send-email-loic.poulain@linaro.org>
Date:   Thu, 26 Aug 2021 17:36:03 +0200
From:   Loic Poulain <loic.poulain@...aro.org>
To:     kuba@...nel.org, kvalo@...eaurora.org, davem@...emloft.net
Cc:     netdev@...r.kernel.org, ath11k@...ts.infradead.org,
        regressions@...ts.linux.dev, hemantk@...eaurora.org,
        nschichan@...ebox.fr, manivannan.sadhasivam@...aro.org,
        Loic Poulain <loic.poulain@...aro.org>
Subject: [PATCH] qrtr: mhi: Fix duplicate channel start

commit ce78ffa3ef16 ("net: really fix the build...") handling a merge
conflict causes the mhi_prepare_for_transfer() function to be called
twice (with different flags), leading to QRTR probing issues.

Fixes: ce78ffa3ef16 ("net: really fix the build...")
Signed-off-by: Loic Poulain <loic.poulain@...aro.org>
---
 net/qrtr/mhi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
index 1dc955c..deb8b03 100644
--- a/net/qrtr/mhi.c
+++ b/net/qrtr/mhi.c
@@ -83,11 +83,6 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
 	struct qrtr_mhi_dev *qdev;
 	int rc;
 
-	/* start channels */
-	rc = mhi_prepare_for_transfer(mhi_dev, 0);
-	if (rc)
-		return rc;
-
 	qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
 	if (!qdev)
 		return -ENOMEM;
-- 
2.7.4