netdev - Re: [PATCH net] net/mlx5: Remove all auxiliary devices at the unregister event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f99c4adb48111f9338fc6605680e5d10c54332a0.camel@nvidia.com>
Date:   Thu, 26 Aug 2021 17:14:44 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     Leon Romanovsky <leonro@...dia.com>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     Roi Dayan <roid@...dia.com>,
        "yangyicong@...ilicon.com" <yangyicong@...ilicon.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Dmytro Linkin <dlinkin@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net/mlx5: Remove all auxiliary devices at the
 unregister event

On Wed, 2021-08-25 at 07:18 -0700, Jakub Kicinski wrote:
> On Wed, 25 Aug 2021 12:01:22 +0300 Leon Romanovsky wrote:
> > On Sat, Aug 21, 2021 at 03:05:11PM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@...dia.com>
> > > 
> > > The call to mlx5_unregister_device() means that mlx5_core driver
> > > is
> > > removed. In such scenario, we need to disregard all other flags
> > > like
> > > attach/detach and forcibly remove all auxiliary devices.
> > > 
> > > Fixes: a5ae8fc9058e ("net/mlx5e: Don't create devices during
> > > unload flow")
> > > Tested-and-Reported-by: Yicong Yang <yangyicong@...ilicon.com>
> > > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> > > ---
> > >  drivers/net/ethernet/mellanox/mlx5/core/dev.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)  
> > 
> > Any reason do not apply this patch?
> 
> 'Awaiting upstream' => we expect Saeed to take it via his tree.
> If special handling is requested is should be noted somewhere.

Planned for submission in my next pr.
I don't send net prs until i have enough content, to avoid spamming the
mailing list :).