netdev - Re: [PATCH net-next v3 2/3] bnxt: count packets discarded because of netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimh-oLG7zNBgSCYqS1aJh5ivBJJK+5kkL1kqJU5NOHctA@mail.gmail.com>
Date:   Thu, 26 Aug 2021 11:43:58 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, olteanv@...il.com
Subject: Re: [PATCH net-next v3 2/3] bnxt: count packets discarded because of netpoll

On Thu, Aug 26, 2021 at 6:12 AM Jakub Kicinski <kuba@...nel.org> wrote:

> @@ -10646,11 +10653,15 @@ static void bnxt_get_ring_stats(struct bnxt *bp,
>                 stats->multicast += BNXT_GET_RING_STATS64(sw, rx_mcast_pkts);
>
>                 stats->tx_dropped += BNXT_GET_RING_STATS64(sw, tx_error_pkts);
> +
> +               bsw_stats->rx.rx_netpoll_discards +=
> +                       cpr->sw_stats.rx.rx_netpoll_discards;

Can we just add these rx_netpoll_discards counters directly to
stats->rx_dropped?  It looks simpler if we do it that way, right?

>         }
>  }
>
>  static void bnxt_add_prev_stats(struct bnxt *bp,
> -                               struct rtnl_link_stats64 *stats)
> +                               struct rtnl_link_stats64 *stats,
> +                               struct bnxt_sw_stats *bsw_stats)
>  {
>         struct rtnl_link_stats64 *prev_stats = &bp->net_stats_prev;
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)