netdev - Re: [PATCH net-next v3] tcp: enable mid stream window clamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90c5570b-00e1-7f3a-c42a-7525a8d02cdf@gmail.com>
Date:   Thu, 26 Aug 2021 15:51:55 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Neil Spring <ntspring@...com>, davem@...emloft.net,
        edumazet@...gle.com
Cc:     yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org,
        netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net-next v3] tcp: enable mid stream window clamp



On 8/25/21 2:01 PM, Neil Spring wrote:
> The TCP_WINDOW_CLAMP socket option is defined in tcp(7) to "Bound the size
> of the advertised window to this value."  Window clamping is distributed
> across two variables, window_clamp ("Maximal window to advertise" in
> tcp.h) and rcv_ssthresh ("Current window clamp").
> 
> This patch updates the function where the window clamp is set to also
> reduce the current window clamp, rcv_sshthresh, if needed.  With this,
> setting the TCP_WINDOW_CLAMP option has the documented effect of limiting
> the window.
> 
> Signed-off-by: Neil Spring <ntspring@...com>
> ---
> v2: - fix email formatting
> 
> v3: - address comments by setting rcv_ssthresh based on prior window 
> 

SGTM, thanks.

Signed-off-by: Eric Dumazet <edumazet@...gle.com>