netdev - Re: [PATCH net-next 3/3] bnxt: count discards due to memory allocation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210826002257.yffn4cf2dtyr23q3@skbuf>
Date:   Thu, 26 Aug 2021 03:22:57 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     michael.chan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] bnxt: count discards due to memory
 allocation errors

Hi Jakub,

On Wed, Aug 25, 2021 at 04:18:30PM -0700, Jakub Kicinski wrote:
> Count packets dropped due to buffer or skb allocation errors.
> Report as part of rx_dropped, and per-queue in ethtool
> (retaining only the former across down/up cycles).
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 14 +++++++++++++-
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h         |  1 +
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  1 +
>  3 files changed, 15 insertions(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index 25f1327aedb6..f8a28021389b 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -188,6 +188,7 @@ static const char * const bnxt_rx_sw_stats_str[] = {
>  	"rx_l4_csum_errors",
>  	"rx_resets",
>  	"rx_buf_errors",
> +	"rx_oom_discards",

'Could you consider adding "driver" stats under RTM_GETSTATS,
or a similar new structured interface over ethtool?

Looks like the statistic in question has pretty clear semantics,
and may be more broadly useful.'

https://patchwork.ozlabs.org/project/netdev/patch/20201017213611.2557565-2-vladimir.oltean@nxp.com/

>  };
>  
>  static const char * const bnxt_cmn_sw_stats_str[] = {
> -- 
> 2.31.1
>