netdev - Re: [PATCH V2 ethtool-next 1/2] update UAPI header copies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210826094530.x4m3pvkuvtorwz6d@lion.mk-sys.cz>
Date:   Thu, 26 Aug 2021 11:45:30 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Guangbin Huang <huangguangbin2@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, amitc@...lanox.com,
        idosch@...sch.org, andrew@...n.ch, o.rempel@...gutronix.de,
        f.fainelli@...il.com, jacob.e.keller@...el.com, mlxsw@...lanox.com,
        netdev@...r.kernel.org, lipeng321@...wei.com
Subject: Re: [PATCH V2 ethtool-next 1/2] update UAPI header copies

On Wed, Aug 25, 2021 at 03:45:12PM +0800, Guangbin Huang wrote:
> Update to kernel commit 5b4ecc3d4c4a.
> 
> Signed-off-by: Guangbin Huang <huangguangbin2@...wei.com>
> ---
>  uapi/linux/ethtool.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/uapi/linux/ethtool.h b/uapi/linux/ethtool.h
> index c6ec1111ffa3..bd1f09b23cf5 100644
> --- a/uapi/linux/ethtool.h
> +++ b/uapi/linux/ethtool.h
> @@ -637,6 +637,8 @@ enum ethtool_link_ext_substate_link_logical_mismatch {
>  enum ethtool_link_ext_substate_bad_signal_integrity {
>  	ETHTOOL_LINK_EXT_SUBSTATE_BSI_LARGE_NUMBER_OF_PHYSICAL_ERRORS = 1,
>  	ETHTOOL_LINK_EXT_SUBSTATE_BSI_UNSUPPORTED_RATE,
> +	ETHTOOL_LINK_EXT_SUBSTATE_BSI_SERDES_REFERENCE_CLOCK_LOST,
> +	ETHTOOL_LINK_EXT_SUBSTATE_BSI_SERDES_ALOS,
>  };
>  
>  /* More information in addition to ETHTOOL_LINK_EXT_STATE_CABLE_ISSUE. */
> -- 
> 2.8.1
> 

I replaced this commit with a full update of uapi headers. The point is
that if we keep cherry picking only specific changes in the headers, it
will become harder and harder to check if something is missing or if we
diverged from kernel. This is why an update of uapi headers should
always update all of them to the state of the same kernel commit
(usually current master or net-next tree).

I added the link to ethtool-import-uapi script to devel documentation on
the ethtool web page make things easier.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)