netdev - Re: [PATCH net-next 3/3] bnxt: count discards due to memory allocation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210826004208.porufhkzwtc3zgny@skbuf>
Date:   Thu, 26 Aug 2021 03:42:08 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     michael.chan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/3] bnxt: count discards due to memory
 allocation errors

On Wed, Aug 25, 2021 at 05:35:37PM -0700, Jakub Kicinski wrote:
> On Thu, 26 Aug 2021 03:22:57 +0300 Vladimir Oltean wrote:
> > 'Could you consider adding "driver" stats under RTM_GETSTATS,
> > or a similar new structured interface over ethtool?
> >
> > Looks like the statistic in question has pretty clear semantics,
> > and may be more broadly useful.'
>
> It's commonly reported per ring, I need for make a home for these
> first by adding that damn netlink queue API. It's my next project.
>
> I can drop the ethtool stat from this patch if you have a strong
> preference.

I don't have any strong preference, far from it. What would you do if
you were reviewing somebody else's patch which made the same change?