netdev - Re: [PATCH iproute2-next 10/17] bridge: vlan: add global mcast_last_member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <254468ad-0170-5ef3-2266-35f2beaf1f2f@gmail.com>
Date:   Fri, 27 Aug 2021 11:21:02 -0700
From:   David Ahern <dsahern@...il.com>
To:     Nikolay Aleksandrov <nikolay@...dia.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Roopa Prabhu <roopa@...dia.com>,
        Joachim Wiberg <troglobit@...il.com>
Subject: Re: [PATCH iproute2-next 10/17] bridge: vlan: add global
 mcast_last_member_interval option

On 8/27/21 10:39 AM, Nikolay Aleksandrov wrote:
> 
> 
> ------------------------------------------------------------------------
> *From:* David Ahern <dsahern@...il.com>
> *Sent:* Friday, 27 August 2021, 20:15
> *To:* Nikolay Aleksandrov; netdev@...r.kernel.org
> *Cc:* Roopa Prabhu; Joachim Wiberg; Nikolay Aleksandrov
> *Subject:* Re: [PATCH iproute2-next 10/17] bridge: vlan: add global
> mcast_last_member_interval option
> 
> On 8/26/21 6:05 AM, Nikolay Aleksandrov wrote:
>> @@ -42,6 +42,7 @@ static void usage(void)
>>                "                                                      [ mcast_igmp_version IGMP_VERSION ]\n"
>>                "                                                      [ mcast_mld_version MLD_VERSION ]\n"
>>                "                                                      [ mcast_last_member_count LAST_MEMBER_COUNT ]\n"
>> +             "                                                      [ mcast_last_member_interval LAST_MEMBER_INTERVAL ]\n"
>>                "                                                      [ mcast_startup_query_count STARTUP_QUERY_COUNT ]\n"
>>                "       bridge vlan global { show } [ dev DEV ] [ vid VLAN_ID ]\n");
>>        exit(-1);
> 
> line lengths are too long. The LAST_MEMBER_INTERVAL is at 107 characters
> wide just in what is displayed to the user. Let's keep those under 100.
> 
>>>
> 
> To be clear do you want me to break the help line or use a format string
> to print it?
> 
> 
> 

Something like this:

"       bridge vlan global { set } vid VLAN_ID dev DEV\n"
"                      [ mcast_snooping MULTICAST_SNOOPING ]\n"
"                      [ mcast_igmp_version IGMP_VERSION ]\n"
"                      [ mcast_mld_version MLD_VERSION ]\n"
"                      [ mcast_last_member_count LAST_MEMBER_COUNT ]\n"

(email line lengths are too short forcing wrapping too early, but that
is the intent with line lengths in the 80-90 range