netdev - Re: [PATCH net-next 00/11] bnxt_en: Implement new driver APIs to send FW messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSqzrxMtoZl1/uDc@lunn.ch>
Date:   Sun, 29 Aug 2021 00:07:43 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org,
        edwin.peer@...adcom.com, gospo@...adcom.com
Subject: Re: [PATCH net-next 00/11] bnxt_en: Implement new driver APIs to
 send FW messages

On Sat, Aug 28, 2021 at 05:58:19PM -0400, Michael Chan wrote:
> The current driver APIs to send messages to the firmware allow only one
> outstanding message in flight.  There is only one buffer for the firmware
> response for each firmware channel.  To send a firmware message, all
> callers must take a mutex and it is released after the firmware response
> has been read.  This scheme does not allow multiple firmware messages
> in flight.  Firmware may take a long time to respond to some messages
> (e.g. NVRAM related ones) and this causes the mutex to be held for
> a long time, blocking other callers.
> 
> This patchset intoduces the new driver APIs to address the above
> shortcomings.  All callers are then updated to use the new APIs.

Hi Michael

Does the firmware already support this? Or is a firmware upgrade also
required.

	Andrew