netdev - Re: [PATCH net 1/1] atlantic: Fix driver resume flow.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210827172302.0d6c6b6f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 27 Aug 2021 17:23:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sudarsana Reddy Kalluru <skalluru@...vell.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <irusskikh@...vell.com>
Subject: Re: [PATCH net 1/1] atlantic: Fix driver resume flow.

On Fri, 27 Aug 2021 04:52:25 -0700 Sudarsana Reddy Kalluru wrote:
> Driver crashes when restoring from the Hibernate. In the resume flow,
> driver need to clean up the older nic/vec objects and re-initialize them.
> 
> Fixes: 8aaa112a57c1d ("net: atlantic: refactoring pm logic")
> Signed-off-by: Sudarsana Reddy Kalluru <skalluru@...vell.com>
> Signed-off-by: Igor Russkikh <irusskikh@...vell.com>
> ---
>  drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
> index 59253846e885..f26d03735619 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
> @@ -417,6 +417,9 @@ static int atl_resume_common(struct device *dev, bool deep)
>  	pci_restore_state(pdev);
>  
>  	if (deep) {
> +		/* Reinitialize Nic/Vecs objects */
> +		aq_nic_deinit(nic, !nic->aq_hw->aq_nic_cfg->wol);

Why does the deinit() happen on resume, not suspend?

>  		ret = aq_nic_init(nic);
>  		if (ret)
>  			goto err_exit;