netdev - RE: [PATCH net-next 10/13] ravb: Factorise ravb_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OS0PR01MB5922CEDA81D7B0468C48B34086C99@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Sat, 28 Aug 2021 12:45:16 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Andrew Lunn <andrew@...n.ch>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Adam Ford <aford173@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>
Subject: RE: [PATCH net-next 10/13] ravb: Factorise ravb_set_features

Hi Sergei,

> Subject: Re: [PATCH net-next 10/13] ravb: Factorise ravb_set_features
> 
> On 28.08.2021 12:20, Biju Das wrote:
> 
> [...]
> >>> RZ/G2L supports HW checksum on RX and TX whereas R-Car supports on RX.
> >>> Factorise ravb_set_features to support this feature.
> >>>
> >>> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> >>> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >>> ---
> >>>   drivers/net/ethernet/renesas/ravb.h      |  1 +
> >>>   drivers/net/ethernet/renesas/ravb_main.c | 15 +++++++++++++--
> >>>   2 files changed, 14 insertions(+), 2 deletions(-)
> >>>
> >> [...]
> >>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> >>> b/drivers/net/ethernet/renesas/ravb_main.c
> >>> index 1f9d9f54bf1b..1789309c4c03 100644
> >>> --- a/drivers/net/ethernet/renesas/ravb_main.c
> >>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> >>> @@ -1901,8 +1901,8 @@ static void ravb_set_rx_csum(struct net_device
> >> *ndev, bool enable)
> >>>   	spin_unlock_irqrestore(&priv->lock, flags);  }
> >>>
> >>> -static int ravb_set_features(struct net_device *ndev,
> >>> -			     netdev_features_t features)
> >>> +static int ravb_set_features_rx_csum(struct net_device *ndev,
> >>> +				     netdev_features_t features)
> >>
> >>     How about ravb_set_features_rcar() or s/th alike?
> >
> > What about
> >
> > ravb_rcar_set_features_csum()?
> >
> > and
> >
> > ravb_rgeth_set_features_csum()?
>  >
> > If you are ok with this name change I will incorporate this changes in
> next - RFC patchset?
> >
> > If you still want ravb_set_features_rcar() and
> ravb_set_features_rgeth(), I am ok with that as well.
> >
> > Please let me know, which name you like.
> 
>     Looking back at sh_eth, my variant seems to fit better...

OK, will take care this name change in next RFC- patchset which includes RZ/G2L support.

Regards,
Biju