netdev - Re: [PATCH net 2/5] ice: remove dead code for allocating pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210827174339.5db00f54@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 27 Aug 2021 17:43:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, Jacob Keller <jacob.e.keller@...el.com>,
        netdev@...r.kernel.org, richardcochran@...il.com,
        maciej.machnikowski@...el.com,
        Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net 2/5] ice: remove dead code for allocating pin_config

On Fri, 27 Aug 2021 13:43:55 -0700 Tony Nguyen wrote:
> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> We have code in the ice driver which allocates the pin_config structure
> if n_pins is > 0, but we never set n_pins to be greater than zero.
> There's no reason to keep this code until we actually have pin_config
> support. Remove this. We can re-add it properly when we implement
> support for pin_config for E810-T devices.
> 
> Fixes: 172db5f91d5f ("ice: add support for auxiliary input/output pins")
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Tested-by: Gurucharan G <gurucharanx.g@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Removing dead code is not really a fix. Let's see if Linus cuts 5.14
this weekend, in which case it won't matter.