netdev - RE: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message to get SyncE status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB49514899CD7CE514E792CE40EACA9@PH0PR11MB4951.namprd11.prod.outlook.com>
Date:   Sun, 29 Aug 2021 08:19:54 +0000
From:   "Machnikowski, Maciej" <maciej.machnikowski@...el.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "abyagowi@...com" <abyagowi@...com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: RE: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE message
 to get SyncE status

> From: Andrew Lunn <andrew@...n.ch>
> Sent: Saturday, August 28, 2021 11:56 PM
> To: Machnikowski, Maciej <maciej.machnikowski@...el.com>
> Cc: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org;
> richardcochran@...il.com; abyagowi@...com; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net; kuba@...nel.org;
> linux-kselftest@...r.kernel.org
> Subject: Re: [RFC net-next 1/2] rtnetlink: Add new RTM_GETSYNCESTATE
> message to get SyncE status
> 
> On Sat, Aug 28, 2021 at 11:12:47PM +0200, Maciej Machnikowski wrote:
> > This patch adds the new RTM_GETSYNCESTATE message to query the
> status
> > of SyncE syntonization on the device.
> 
> Hi Maciej
> 
> You use syntonization a few times. Is this a miss spelling for synchronisation,
> or a SyncE terms?

Hi! Thanks for your comments!

Syntonization is a specific term for frequency synchronization.


> >
> >  struct prefixmsg {
> > @@ -569,7 +572,7 @@ struct prefixmsg {
> >  	unsigned char	prefix_pad3;
> >  };
> >
> > -enum
> > +enum
> >  {
> >  	PREFIX_UNSPEC,
> >  	PREFIX_ADDRESS,
> 
> You appear to have a number of white space changes here. Please put them
> into a separate patch, or drop them.

Will fix and resubmit along with the fix for issues found by the robot

Thanks!
Maciek

> 
>      Andrew