netdev - Re: [RFC PATCH v2 net-next 0/5] Let phylink manage in-band AN for the PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210830183015.GY22278@shell.armlinux.org.uk>
Date:   Mon, 30 Aug 2021 19:30:15 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, Antoine Tenart <atenart@...nel.org>,
        Quentin Schulz <quentin.schulz@...tlin.com>,
        Michael Walle <michael@...le.cc>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Maxim Kochetkov <fido_max@...ox.ru>,
        Bjarni Jonasson <bjarni.jonasson@...rochip.com>,
        Steen Hegelund <steen.hegelund@...rochip.com>,
        UNGLinuxDriver@...rochip.com, bcm-kernel-feedback-list@...adcom.com
Subject: Re: [RFC PATCH v2 net-next 0/5] Let phylink manage in-band AN for
 the PHY

Can we postpone this after this merge window please, so I've got time
to properly review this. Thanks.

On Mon, Aug 30, 2021 at 06:52:45PM +0300, Vladimir Oltean wrote:
> This small series creates a configuration knob for PHY drivers which use
> serial MII-side interfaces and support clause 37 in-band auto-negotiation
> there.
> 
> Changes in v2:
> Incorporated feedback from Russell, which was to consider PHYs on SFP
> modules too, and unify phylink's detection of PHYs with broken in-band
> autoneg with the newly introduced PHY driver methods.
> https://patchwork.kernel.org/project/netdevbpf/cover/20210212172341.3489046-1-olteanv@gmail.com/
> 
> This change set is only superficially tested, hence the RFC tag. It does
> what I need on the NXP boards with on-board PHYs that I have, and also
> seems to behave the same as before when I use a 1G SGMII SFP module with
> the Marvell 88E1111 PHY (the only thing I have). I do not have the
> ability to test the Methode DM7052 SFP module for the bcm84881.c driver
> change, since I don't have that.
> 
> Posting the patch series mostly to figure out whether I understood the
> change request correctly.
> 
> Vladimir Oltean (5):
>   net: phylink: pass the phy argument to phylink_sfp_config
>   net: phylink: introduce a generic method for querying PHY in-band
>     autoneg capability
>   net: phy: bcm84881: move the in-band capability check where it belongs
>   net: phylink: explicitly configure in-band autoneg for PHYs that
>     support it
>   net: phy: mscc: configure in-band auto-negotiation for VSC8514
> 
>  drivers/net/phy/bcm84881.c       | 10 ++++
>  drivers/net/phy/mscc/mscc.h      |  2 +
>  drivers/net/phy/mscc/mscc_main.c | 20 +++++++
>  drivers/net/phy/phy.c            | 25 +++++++++
>  drivers/net/phy/phylink.c        | 93 +++++++++++++++++++++++++-------
>  include/linux/phy.h              | 24 +++++++++
>  6 files changed, 154 insertions(+), 20 deletions(-)
> 
> -- 
> 2.25.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!