netdev - Re: [PATCH v3 bpf-next 2/7] bpf: add bpf_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzaGgyCpVLDc5g96+hze-HXfduERQMHDev0O0Ea6NdhGdQ@mail.gmail.com>
Date:   Mon, 30 Aug 2021 16:35:28 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Dave Marchevsky <davemarchevsky@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Yonghong Song <yhs@...com>, Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 bpf-next 2/7] bpf: add bpf_trace_vprintk helper

On Fri, Aug 27, 2021 at 10:20 PM Dave Marchevsky <davemarchevsky@...com> wrote:
>
> This helper is meant to be "bpf_trace_printk, but with proper vararg
> support". Follow bpf_snprintf's example and take a u64 pseudo-vararg
> array. Write to /sys/kernel/debug/tracing/trace_pipe using the same
> mechanism as bpf_trace_printk.
>
> Signed-off-by: Dave Marchevsky <davemarchevsky@...com>
> ---

LGTM.

Acked-by: Andrii Nakryiko <andrii@...nel.org>

>  include/linux/bpf.h            |  1 +
>  include/uapi/linux/bpf.h       |  9 ++++++
>  kernel/bpf/core.c              |  5 ++++
>  kernel/bpf/helpers.c           |  2 ++
>  kernel/trace/bpf_trace.c       | 52 +++++++++++++++++++++++++++++++++-
>  tools/include/uapi/linux/bpf.h |  9 ++++++
>  6 files changed, 77 insertions(+), 1 deletion(-)
>

[...]