netdev - Re: [PATCH net-next] af_unix: fix potential NULL deref in unix_dgram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpUVr8XxtMU_P1Lo7iUo7eGtor7xRNsMA8yKqPE+CzoYxQ@mail.gmail.com>
Date:   Tue, 31 Aug 2021 11:06:09 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Cong Wang <cong.wang@...edance.com>,
        Alexei Starovoitov <ast@...nel.org>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net-next] af_unix: fix potential NULL deref in unix_dgram_connect()

On Mon, Aug 30, 2021 at 10:21 AM Eric Dumazet <eric.dumazet@...il.com> wrote:
> @@ -1805,6 +1807,7 @@ static int unix_dgram_sendmsg(struct socket *sock, struct msghdr *msg,
>
>                         unix_state_unlock(sk);
>
> +                       sk->sk_state = TCP_CLOSE;

Does this need to be moved before the unix_state_unlock()?

The rest looks good to me.

Thanks.