netdev - Re: [PATCH net] ipv4: fix endianness issue in inet_rtm_getroute_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b73935ca-f82e-16a7-42de-cfbaf13e1fea@gmail.com>
Date:   Mon, 30 Aug 2021 19:34:17 -0700
From:   David Ahern <dsahern@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Roopa Prabhu <roopa@...dia.com>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net] ipv4: fix endianness issue in
 inet_rtm_getroute_build_skb()

On 8/30/21 7:02 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> The UDP length field should be in network order.
> This removes the following sparse error:
> 
> net/ipv4/route.c:3173:27: warning: incorrect type in assignment (different base types)
> net/ipv4/route.c:3173:27:    expected restricted __be16 [usertype] len
> net/ipv4/route.c:3173:27:    got unsigned long
> 
> Fixes: 404eb77ea766 ("ipv4: support sport, dport and ip_proto in RTM_GETROUTE")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Roopa Prabhu <roopa@...dia.com>
> Cc: David Ahern <dsahern@...nel.org>
> ---
>  net/ipv4/route.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>