netdev - RE: [PATCH v12 bpf-next 04/18] net: mvneta: simplify mvneta_swbm_add_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <612ebc69e8a00_6b872086d@john-XPS-13-9370.notmuch>
Date:   Tue, 31 Aug 2021 16:34:01 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     lorenzo.bianconi@...hat.com, davem@...emloft.net, kuba@...nel.org,
        ast@...nel.org, daniel@...earbox.net, shayagr@...zon.com,
        john.fastabend@...il.com, dsahern@...nel.org, brouer@...hat.com,
        echaudro@...hat.com, jasowang@...hat.com,
        alexander.duyck@...il.com, saeed@...nel.org,
        maciej.fijalkowski@...el.com, magnus.karlsson@...el.com,
        tirthendu.sarkar@...el.com, toke@...hat.com
Subject: RE: [PATCH v12 bpf-next 04/18] net: mvneta: simplify
 mvneta_swbm_add_rx_fragment management

Lorenzo Bianconi wrote:
> Relying on xdp mb bit, remove skb_shared_info structure allocated on the
> stack in mvneta_rx_swbm routine and simplify mvneta_swbm_add_rx_fragment
> accessing skb_shared_info in the xdp_buff structure directly. There is no
> performance penalty in this approach since mvneta_swbm_add_rx_fragment
> is run just for multi-buff use-case.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>