netdev - Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book Flex2 Alpha

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddcb88a3f6614ef6138b68375a22fbba1b068ff3.camel@intel.com>
Date:   Tue, 31 Aug 2021 06:36:15 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "jmforbes@...uxtx.org" <jmforbes@...uxtx.org>
CC:     "yj99.shin@...sung.com" <yj99.shin@...sung.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        "Baruch, Yaara" <yaara.baruch@...el.com>,
        "ihab.zhaika@...el.com" <ihab.zhaika@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Gottlieb, Matti" <matti.gottlieb@...el.com>,
        "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
        "jh80.chung@...sung.com" <jh80.chung@...sung.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi Add support for ax201 in Samsung Galaxy Book
 Flex2 Alpha

On Wed, 2021-08-25 at 13:07 -0500, Justin Forbes wrote:
> On Sat, Aug 21, 2021 at 8:34 AM Kalle Valo <kvalo@...eaurora.org> wrote:
> > 
> > Jaehoon Chung <jh80.chung@...sung.com> writes:
> > 
> > > Hi
> > > 
> > > On 8/9/21 8:09 AM, Jaehoon Chung wrote:
> > > > Hi
> > > > 
> > > > On 7/10/21 2:32 AM, Justin Forbes wrote:
> > > > > On Fri, Jul 2, 2021 at 5:32 PM Justin M. Forbes
> > > > > <jforbes@...oraproject.org> wrote:
> > > > > > 
> > > > > > The Samsung Galaxy Book Flex2 Alpha uses an ax201 with the ID a0f0/6074.
> > > > > > This works fine with the existing driver once it knows to claim it.
> > > > > > Simple patch to add the device.
> > > > > > 
> > > > > > Signed-off-by: Justin M. Forbes <jforbes@...oraproject.org>
> > > 
> > > If this patch is merged, can this patch be also applied on stable tree?
> > 
> > Luca, what should we do with this patch?
> > 
> > --
> > https://patchwork.kernel.org/project/linux-wireless/list/
> > 
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> 
> 
> Is that to imply that there is an issue with the submission?  Happy to
> fix any problems, but it would nice to get this in soon.  I know the
> 5.14 merge window was already opened when I sent it, but the 5.15 MR
> is opening soon.  Hardware is definitely shipping and in users hands.

Sorry for the delay here.  This fell between the cracks.

Kalle can you apply this directly to your tree? I'll assign it to you.
And, if possible, add the cc-stable tag so it gets picked up. :)

Longer reasoning: generally we detect the hardware in a more
programmatic way, by checking the type from registers (and not relying
entirely on the PCI IDs), but for some reason this type of device is
still using the legacy way of matching the exact PCI ID to a device
type.  Thus, this patch is needed, at least for now.

Thanks!

--
Cheers,
Luca.