netdev - Re: [PATCH net-next] fou: remove sparse errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163040820840.5377.12465802324666851427.git-patchwork-notify@kernel.org>
Date:   Tue, 31 Aug 2021 11:10:08 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        edumazet@...gle.com
Subject: Re: [PATCH net-next] fou: remove sparse errors

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 30 Aug 2021 20:26:08 -0700 you wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> We need to add __rcu qualifier to avoid these errors:
> 
> net/ipv4/fou.c:250:18: warning: incorrect type in assignment (different address spaces)
> net/ipv4/fou.c:250:18:    expected struct net_offload const **offloads
> net/ipv4/fou.c:250:18:    got struct net_offload const [noderef] __rcu **
> net/ipv4/fou.c:251:15: error: incompatible types in comparison expression (different address spaces):
> net/ipv4/fou.c:251:15:    struct net_offload const [noderef] __rcu *
> net/ipv4/fou.c:251:15:    struct net_offload const *
> net/ipv4/fou.c:272:18: warning: incorrect type in assignment (different address spaces)
> net/ipv4/fou.c:272:18:    expected struct net_offload const **offloads
> net/ipv4/fou.c:272:18:    got struct net_offload const [noderef] __rcu **
> net/ipv4/fou.c:273:15: error: incompatible types in comparison expression (different address spaces):
> net/ipv4/fou.c:273:15:    struct net_offload const [noderef] __rcu *
> net/ipv4/fou.c:273:15:    struct net_offload const *
> net/ipv4/fou.c:442:18: warning: incorrect type in assignment (different address spaces)
> net/ipv4/fou.c:442:18:    expected struct net_offload const **offloads
> net/ipv4/fou.c:442:18:    got struct net_offload const [noderef] __rcu **
> net/ipv4/fou.c:443:15: error: incompatible types in comparison expression (different address spaces):
> net/ipv4/fou.c:443:15:    struct net_offload const [noderef] __rcu *
> net/ipv4/fou.c:443:15:    struct net_offload const *
> net/ipv4/fou.c:489:18: warning: incorrect type in assignment (different address spaces)
> net/ipv4/fou.c:489:18:    expected struct net_offload const **offloads
> net/ipv4/fou.c:489:18:    got struct net_offload const [noderef] __rcu **
> net/ipv4/fou.c:490:15: error: incompatible types in comparison expression (different address spaces):
> net/ipv4/fou.c:490:15:    struct net_offload const [noderef] __rcu *
> net/ipv4/fou.c:490:15:    struct net_offload const *
> net/ipv4/udp_offload.c:170:26: warning: incorrect type in assignment (different address spaces)
> net/ipv4/udp_offload.c:170:26:    expected struct net_offload const **offloads
> net/ipv4/udp_offload.c:170:26:    got struct net_offload const [noderef] __rcu **
> net/ipv4/udp_offload.c:171:23: error: incompatible types in comparison expression (different address spaces):
> net/ipv4/udp_offload.c:171:23:    struct net_offload const [noderef] __rcu *
> net/ipv4/udp_offload.c:171:23:    struct net_offload const *
> 
> [...]

Here is the summary with links:
  - [net-next] fou: remove sparse errors
    https://git.kernel.org/netdev/net-next/c/8d65cd8d25fa

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html