netdev - RE: [RFC v3 net-next 1/2] rtnetlink: Add new RTM_GETEECSTATE message to get SyncE status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB495871A89632732B0028404EEACC9@SJ0PR11MB4958.namprd11.prod.outlook.com>
Date:   Tue, 31 Aug 2021 11:33:25 +0000
From:   "Machnikowski, Maciej" <maciej.machnikowski@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "abyagowi@...com" <abyagowi@...com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: RE: [RFC v3 net-next 1/2] rtnetlink: Add new RTM_GETEECSTATE message
 to get SyncE status

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Monday, August 30, 2021 8:14 PM
> To: Machnikowski, Maciej <maciej.machnikowski@...el.com>
> Subject: Re: [RFC v3 net-next 1/2] rtnetlink: Add new RTM_GETEECSTATE

> > +#define IF_EEC_PIN_UNKNOWN	0xFF
> > +
> > +struct if_eec_state_msg {
> > +	__u32 ifindex;
> > +	__u8 state;
> > +	__u8 src;
> > +	__u8 pin;
> > +	__u8 pad;
> > +};
> 
> Please break this structure up into individual attributes.
> 
> This way you won't have to expose the special PIN_UNKNOWN value to user
> space (skip the invalid attrs instead).

Addressed all other comments. 
For this one - I'll add flags which will indicate validity of all values. Since 
this structure is self-contained and addresses the generic need for state 
report.

Will resubmit as a patch.

Thanks!
Maciek