netdev - Re: [PATCH] net: phy: fix autoneg invalid error state of GBSR register.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6bac579b-5261-f96b-7a26-61cfe5f8ce87@gmail.com>
Date:   Wed, 1 Sep 2021 07:55:17 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     马强 <maqianga@...ontech.com>,
        Andrew Lunn <andrew@...n.ch>
Cc:     davem <davem@...emloft.net>, netdev <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Ming Wang <wangming01@...ngson.cn>
Subject: Re: [PATCH] net: phy: fix autoneg invalid error state of GBSR
 register.



On 9/1/2021 6:40 AM, 马强 wrote:
>  > > > It looks like you are using an old tree.
>  > > Yes, it is linux-4.19.y, since 4.19.y does not have 
> autoneg_complete flag,，
>  > > This patch adds the condition before
>  > > reading GBSR register to fix this error state.
>  >
>  > So you first need to fix it in net/master, and then backport it to
>  > older kernels.
> 
> This patch is modified according to the contents of the latest kernels,
> the following is a reference:
> [ Upstream commit b6163f194c699ff75fa6aa4565b1eb8946c2c652 ]
> [ Upstream commit 4950c2ba49cc6f2b38dbedcfa0ff67acf761419a ]

Then you need to be extremely clear in the commit message which specific 
branch you are targeting, which commits you used as a reference, and how 
you are fixing the problem. Also, the register is commonly named BMSR 
(Basic Mode Status Register), no idea what GBSR means.
-- 
Florian