netdev - Re: [PATCH net-next v2 04/11] bnxt_en: introduce new firmware message API based on DMA pools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Sep 2021 10:35:06 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Edwin Peer <edwin.peer@...adcom.com>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v2 04/11] bnxt_en: introduce new firmware message
 API based on DMA pools

On Wed, Sep 1, 2021 at 9:57 AM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Sun, Aug 29, 2021 at 03:34:59AM -0400, Michael Chan wrote:
> > From: Edwin Peer <edwin.peer@...adcom.com>
> >
> > This change constitutes a major step towards supporting multiple
> > firmware commands in flight by maintaining a separate response buffer
> > for the duration of each request. These firmware commands are also
> > known as Hardware Resource Manager (HWRM) commands.  Using separate
> > response buffers requires an API change in order for callers to be
> > able to free the buffer when done.
> >
>
> parisc:allmodconfig, and probably others:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_init_board':
> drivers/net/ethernet/broadcom/bnxt/bnxt.c:12280:27: error: 'struct bnxt' has no member named 'db_lock'
>
> There is a difference between "#ifdef writeq" and "#if BITS_PER_LONG == 32".

Yes.  It is already fixed in this commit:

c6132f6f2e682c958f7022ecfd8bec35723a1a9d
bnxt_en: Fix 64-bit doorbell operation on 32-bit kernels

Thanks.