netdev - Re: [PATCH] p54: Remove obsolete comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Sep 2021 19:40:00 +0200
From:   Christian Lamparter <chunkeey@...il.com>
To:     Wan Jiabing <wanjiabing@...o.com>,
        Christian Lamparter <chunkeey@...glemail.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kael_w@...h.net
Subject: Re: [PATCH] p54: Remove obsolete comment

On 01/09/2021 04:47, Wan Jiabing wrote:
> In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
> prism54/isl_oid.h is deleted. The comment here is obsolete.
> 
Instead of removing said "obsolete" comment, why not copy the
excellent comment about that "frameburst technology" from the
prism54/isl_oid.h file there?

Cheers,
Christian


> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>   drivers/net/wireless/intersil/p54/fwio.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
> index bece14e4ff0d..1fe072de3e63 100644
> --- a/drivers/net/wireless/intersil/p54/fwio.c
> +++ b/drivers/net/wireless/intersil/p54/fwio.c
> @@ -583,7 +583,6 @@ int p54_set_edcf(struct p54_common *priv)
>   	rtd = 3 * priv->coverage_class;
>   	edcf->slottime += rtd;
>   	edcf->round_trip_delay = cpu_to_le16(rtd);
> -	/* (see prism54/isl_oid.h for further details) */
>   	edcf->frameburst = cpu_to_le16(0);
>   	edcf->flags = 0;
>   	memset(edcf->mapping, 0, sizeof(edcf->mapping));
>