netdev - Re: [PATCH net-next 2/9] ibmvnic: Fix up some comments and messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Sep 2021 16:58:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sukadev Bhattiprolu <sukadev@...ux.ibm.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Brian King <brking@...ux.ibm.com>,
        cforno12@...ux.ibm.com, Dany Madden <drt@...ux.ibm.com>,
        Rick Lindsley <ricklind@...ux.ibm.com>
Subject: Re: [PATCH net-next 2/9] ibmvnic: Fix up some comments and messages

Hi Sukadev,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Sukadev-Bhattiprolu/ibmvnic-Reuse-ltb-rx-tx-pools/20210901-081123
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 29ce8f9701072fc221d9c38ad952de1a9578f95c
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a28141472dfbc71fb3b53b1ba9213b3450435588
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sukadev-Bhattiprolu/ibmvnic-Reuse-ltb-rx-tx-pools/20210901-081123
        git checkout a28141472dfbc71fb3b53b1ba9213b3450435588
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/ibm/ibmvnic.c:579: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Release any rx_pools attached to @adapter.
   drivers/net/ethernet/ibm/ibmvnic.c:752: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Release any tx and tso pools attached to @adapter.


vim +579 drivers/net/ethernet/ibm/ibmvnic.c

   577	
   578	/**
 > 579	 * Release any rx_pools attached to @adapter.
   580	 * Safe to call this multiple times - even if no pools are attached.
   581	 */
   582	static void release_rx_pools(struct ibmvnic_adapter *adapter)
   583	{
   584		struct ibmvnic_rx_pool *rx_pool;
   585		int i, j;
   586	
   587		if (!adapter->rx_pool)
   588			return;
   589	
   590		for (i = 0; i < adapter->num_active_rx_pools; i++) {
   591			rx_pool = &adapter->rx_pool[i];
   592	
   593			netdev_dbg(adapter->netdev, "Releasing rx_pool[%d]\n", i);
   594	
   595			kfree(rx_pool->free_map);
   596			free_long_term_buff(adapter, &rx_pool->long_term_buff);
   597	
   598			if (!rx_pool->rx_buff)
   599				continue;
   600	
   601			for (j = 0; j < rx_pool->size; j++) {
   602				if (rx_pool->rx_buff[j].skb) {
   603					dev_kfree_skb_any(rx_pool->rx_buff[j].skb);
   604					rx_pool->rx_buff[j].skb = NULL;
   605				}
   606			}
   607	
   608			kfree(rx_pool->rx_buff);
   609		}
   610	
   611		kfree(adapter->rx_pool);
   612		adapter->rx_pool = NULL;
   613		adapter->num_active_rx_pools = 0;
   614	}
   615	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (73419 bytes)