netdev - Re: [PATCH net-next 10/11] ptp: ocp: Add IRIG-B output mode control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210902154119.6261c15f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 2 Sep 2021 15:41:19 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     davem@...emloft.net, richardcochran@...il.com,
        netdev@...r.kernel.org, kernel-team@...com, abyagowi@...com
Subject: Re: [PATCH net-next 10/11] ptp: ocp: Add IRIG-B output mode control

On Thu, 2 Sep 2021 10:02:16 -0700 Jonathan Lemon wrote:
> On Wed, Sep 01, 2021 at 05:07:00PM -0700, Jakub Kicinski wrote:
> > On Mon, 30 Aug 2021 16:52:35 -0700 Jonathan Lemon wrote:  
> > > +	err = kstrtou8(buf, 0, &val);
> > > +	if (err)
> > > +		return err;
> > > +	if (val > 7)
> > > +		return -EINVAL;
> > > +
> > > +	reg = ((val & 0x7) << 16);
> > > +
> > > +	spin_lock_irqsave(&bp->lock, flags);
> > > +	iowrite32(0, &bp->irig_out->ctrl);		/* disable */
> > > +	iowrite32(reg, &bp->irig_out->ctrl);		/* change mode */
> > > +	iowrite32(reg | IRIG_M_CTRL_ENABLE, &bp->irig_out->ctrl);
> > > +	spin_unlock_irqrestore(&bp->lock, flags);  
> > 
> > locking  
> 
> Not sure what you mean - all register manipulations are 
> already done under the lock here.

I must have misread and thought it has the same problem as patch 8, 
ignore, sorry.