netdev - Re: [PATCH v4 bpf-next 2/9] selftests/bpf: stop using bpf_program_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzY_WtmNoJ1BGnVOGGeR1BKcqtL9n5rBxxRBurBjQNj0HQ@mail.gmail.com>
Date:   Thu, 2 Sep 2021 15:58:24 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Dave Marchevsky <davemarchevsky@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Yonghong Song <yhs@...com>, Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 bpf-next 2/9] selftests/bpf: stop using bpf_program__load

On Thu, Sep 2, 2021 at 10:20 AM Dave Marchevsky <davemarchevsky@...com> wrote:
>
> bpf_program__load is not supposed to be used directly. Replace it with
> bpf_object__ APIs for the reference_tracking prog_test, which is the
> last offender in bpf selftests.
>
> Some additional complexity is added for this test, namely the use of one
> bpf_object to iterate through progs, while a second bpf_object is
> created and opened/closed to test actual loading of progs. This is
> because the test was doing bpf_program__load then __unload to test
> loading of individual progs and same semantics with
> bpf_object__load/__unload result in failure to load an __unload-ed obj.
>
> Signed-off-by: Dave Marchevsky <davemarchevsky@...com>
> ---

LGTM.

Acked-by: Andrii Nakryiko <andrii@...nel.org>

>  .../bpf/prog_tests/reference_tracking.c       | 39 +++++++++++++++----
>  1 file changed, 31 insertions(+), 8 deletions(-)
>

[...]