netdev - Re: [PATCH v4 bpf-next 6/9] bpftool: only probe trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZ_Vm+EsjtvJu-KunD6rgMXDSJxiNoBq2FRPfe=wis2dw@mail.gmail.com>
Date:   Thu, 2 Sep 2021 16:10:07 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Dave Marchevsky <davemarchevsky@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Yonghong Song <yhs@...com>, Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 bpf-next 6/9] bpftool: only probe trace_vprintk feature
 in 'full' mode

On Thu, Sep 2, 2021 at 10:20 AM Dave Marchevsky <davemarchevsky@...com> wrote:
>
> Since commit 368cb0e7cdb5e ("bpftool: Make probes which emit dmesg
> warnings optional"), some helpers aren't probed by bpftool unless
> `full` arg is added to `bpftool feature probe`.
>
> bpf_trace_vprintk can emit dmesg warnings when probed, so include it.
>
> Signed-off-by: Dave Marchevsky <davemarchevsky@...com>
> ---

Acked-by: Andrii Nakryiko <andrii@...nel.org>

>  tools/bpf/bpftool/feature.c                 |  1 +
>  tools/testing/selftests/bpf/test_bpftool.py | 22 +++++++++------------
>  2 files changed, 10 insertions(+), 13 deletions(-)
>

[...]