netdev - Re: [GIT PULL] Networking for v5.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb2a4294-b0b3-e36f-8828-25fde646be2c@lwfinger.net>
Date:   Thu, 2 Sep 2021 00:55:44 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Jakub Kicinski <kuba@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Luca Coelho <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-wireless@...r.kernel.org,
        Miri Korenblit <miriam.rachel.korenblit@...el.com>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [GIT PULL] Networking for v5.15

On 9/1/21 14:41, Jakub Kicinski wrote:
> On Wed, 1 Sep 2021 12:00:57 -0700 Linus Torvalds wrote:
>> On Tue, Aug 31, 2021 at 1:37 PM Jakub Kicinski <kuba@...nel.org> wrote:
>>>
>>> No conflicts at the time of writing. There were conflicts with
>>> char-misc but I believe Greg dropped the commits in question.
>>
>> Hmm. I already merged this earlier, but didn't notice a new warning on
>> my desktop:
> 
>>    RTNL: assertion failed at net/wireless/core.c (61)
>>    WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:61
>> wiphy_idx_to_wiphy+0xbf/0xd0 [cfg80211]
>>    Call Trace:
>>     nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211]
>>     reg_process_self_managed_hint+0x23d/0x280 [cfg80211]
>>     regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211]
>>     iwl_mvm_init_mcc+0x170/0x190 [iwlmvm]
>>     iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm]
>>     iwl_opmode_register+0xd0/0x130 [iwlwifi]
>>     init_module+0x23/0x1000 [iwlmvm]
>>
>> They all seem to have that same issue, and it looks like the fix would
>> be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look
>> into it very much.
>>
>> This is on my desktop, and I actually don't _use_ the wireless on this
>> machine. I assume it still works despite the warnings, but they should
>> get fixed.
>>
>> I *don't* see these warnings on my laptop where I actually use
>> wireless, but that one uses ath10k_pci, so it seems this is purely a
>> iwlwifi issue.
>>
>> I can't be the only one that sees this. Hmm?
> 
> Mm. Looking thru the recent commits there is a suspicious rtnl_unlock()
> in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage").
> 
> CC Miri, Johannes
> 

I did not get the bisection finished tonight, but commit eb09ae93dabf is not the 
problem.

My bisection has identified commit 7a3f5b0de36 ("netfilter: add netfilter hooks 
to SRv6 data plane") as bad, and commit 9055a2f59162 ("ixp4xx_eth: make ptp 
support a platform driver") as good.

Larry