netdev - Re: [GIT PULL] Networking for v5.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Sep 2021 10:28:10 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        John Stultz <john.stultz@...aro.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [GIT PULL] Networking for v5.15



On 02/09/2021 10:25, Dan Carpenter wrote:
> I'm sorry John,
> 
> Can you try this partial revert?  I'll resend with a commit message if
> it works.
I was about to send similar patch.

This should work, I think your original patch introduced a qrtr packet 
payload alignment constraint which was not there originally.


Tested-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

--srini
> 
> ---
>   net/qrtr/qrtr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index 525e3ea063b1..ec2322529727 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -493,7 +493,7 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const void *data, size_t len)
>   		goto err;
>   	}
>   
> -	if (!size || size & 3 || len != size + hdrlen)
> +	if (!size || len != ALIGN(size, 4) + hdrlen)
>   		goto err;
>   
>   	if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&
>