netdev - Re: [PATCH] iwlwifi: mvm: add rtnl_lock() in iwl_mvm_start_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210902.113908.1070444215922235089.davem@davemloft.net>
Date:   Thu, 02 Sep 2021 11:39:08 +0100 (BST)
From:   David Miller <davem@...emloft.net>
To:     luca@...lho.fi
Cc:     torvalds@...ux-foundation.org, johannes@...solutions.net,
        kuba@...nel.org, kvalo@...eaurora.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        miriam.rachel.korenblitz@...el.com
Subject: Re: [PATCH] iwlwifi: mvm: add rtnl_lock() in
 iwl_mvm_start_get_nvm()

From: Luca Coelho <luca@...lho.fi>
Date: Thu,  2 Sep 2021 13:11:01 +0300

> From: Luca Coelho <luciano.coelho@...el.com>
> 
> Due to a rebase damage, we lost the rtnl_lock() when the patch was
> sent out.  This causes an RTNL imbalance and failed assertions, due to
> missing RTNL protection, for instance:
> 
>   RTNL: assertion failed at net/wireless/reg.c (4025)
>   WARNING: CPU: 60 PID: 1720 at net/wireless/reg.c:4025 regulatory_set_wiphy_regd_sync+0x7f/0x90 [cfg80211]
>   Call Trace:
>    iwl_mvm_init_mcc+0x170/0x190 [iwlmvm]
>    iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm]
>    iwl_opmode_register+0xd0/0x130 [iwlwifi]
>    init_module+0x23/0x1000 [iwlmvm]
> 
> Fix this by adding the missing rtnl_lock() back to the code.
> 
> Fixes: eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage")
> Signed-off-by: Luca Coelho <luciano.coelho@...el.com>

Linus, please just take this directly, thanks.

Acked-by: David S. Miller <davem@...emloft.net>